-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal unit handling to nwm_client
#196
Conversation
@hellkite500 sorry for the large number of files, I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as is. Just had some thoughts on the implementation of convert_values
to ponder.
This PR adds minimal unit handling to
nwm_client
. This is an incremental improvement that includes some housekeeping. Future enhancements will unify thegcp
andhttp
interfaces similar tonwm_client_new
, and transition fromgoogle-cloud-storage
tofsspec
libraries.@aaraney may be interested.
Additions
unit_system
parameter. Setting this parameter to"US"
will convert dataframe values returned byget
to cubic feet per second and updatemeasurement_unit
to"ft^3/s"
.UnitHandler
class with methods to convert units.Removals
gcp_client
has been removed.Changes
gcp
target for pip has been removed andgoogle-cloud-storage
is brought in automatically.Testing
test_units.py
pandas.Series
conversions are tested intest_gcp.py
Notes
Todos
Checklist